-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtk: drop clang 1316 workaround #209097
base: master
Are you sure you want to change the base?
vtk: drop clang 1316 workaround #209097
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to have linkage to Homebrew expat
.
@@ -47,19 +47,6 @@ class Vtk < Formula | |||
uses_from_macos "tcl-tk" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably need depends_on "expat"
to avoid breaking installs on macOS 15. See also Homebrew/brew#19315
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is part of the odd situation of dependents of Python now propagating expat
. Essentially will end up with dozens of formulae with brew expat
linkage unless we handle this differently.
Some alternatives:
- [email protected]: bundle
expat
on Ventura/Sonoma #207887 - [email protected]: use newer expat.h on macOS 13.7.2 and 14.7.2 #207767
- Handle this in
brew
superenv and removeexpat
if only a dependency of[email protected]
Or we just accept expat
usage everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to accept it in dependents to me. There's already linkage anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The formulae impacted (i.e. those with uses_from_macos "expat"
and [email protected]
in dependency tree) are:
- aarch64-elf-gdb
- afflib
- arm-none-eabi-gdb
- gdb ([email protected] for now due to gdbgui)
- gdcm
- graph-tool
- i386-elf-gdb
- opencolorio
- riscv64-elf-gdb
- votca
- vtk
- x86_64-elf-gdb
There were originally more before removing [email protected]
from glib
runtime dependencies.
One thing about current state is there is a higher risk of mixing expat
libraries when installing a combination of Sequoia and Sonoma bottles, i.e. formula bottled/built on Sequoia may be linked to system expat but Sonoma bottle was linked to brew expat and then a project that combines these may crash from multiple expat.
Though we don't really care about this for ncurses
and libxml2
dependents which has similar concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, the existing vtk
bottle is still linked to system expat
so we shouldn't modify dependency until new bottle is needed:
❯ brew linkage vtk | grep expat
/usr/lib/libexpat.1.dylib
Either on next version bump or revision bump like #207100
Apple Clang 1316 was used in Xcode 13.3 - 13.4.1 for Monterey. Since macOS 12.5+ can install Xcode 14, the better option for users is to upgrade macOS/Xcode rather than carrying this workaround we can't verify anymore.